Adding weighted and unweighted polygon offsets using polygon skeletons #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvanmele
reviewed
Jul 5, 2024
| """ | ||
| points = list(points) | ||
| if not TOL.is_allclose(normal_polygon(points, True), [0, 0, 1]): | ||
| raise ValueError("Please pass a polygon with a normal vector of [0, 0, 1].") |
There was a problem hiding this comment.
perhaps something like this is more informative?
"The normal of the polygon should be [0, 0, 1]. The normal of the provided polygon is {}".format(normal_points(points))
| @@ -66,3 +66,76 @@ def create_interior_straight_skeleton_with_holes(points, holes) -> PolylinesNump | |||
| hole = np.asarray(points, dtype=np.float64) | |||
| H.append(hole) | |||
| return straight_skeleton_2.create_interior_straight_skeleton_with_holes(V, H) | |||
|
|
|||
|
|
|||
| def create_offset_polygons_2(points, offset): | |||
There was a problem hiding this comment.
the code is CPython exclusive, so you could add type annotations...
|
|
||
| Returns | ||
| ------- | ||
| list of Polygon |
| return [Polygon(points.tolist()) for points in offset_polygons] | ||
|
|
||
|
|
||
| def create_weighted_offset_polygons_2(points, offset, weights): |
|
|
||
| Returns | ||
| ------- | ||
| list of Polygon |
| "create_offset_polygons_2_inner", | ||
| &pmp_create_offset_polygons_2_inner, | ||
| pybind11::arg("V").noconvert(), | ||
| pybind11::arg("offset").noconvert()); |
There was a problem hiding this comment.
i don't think noconvert is needed on basic types, but i am not sure...
|
Thank you! I've implemented the suggestions |
tomvanmele
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://doc.cgal.org/latest/Straight_skeleton_2/index.html